LensFlare: parameterize number of occlusion steps #3234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a significant amount of CPU time taken when checking for occlusions in the LensFlare compositor listener. This exposes the number of steps taken when checking occlusions to allow users to attempt to speed up this process. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
The SetCamera call passes the current parameters to the compositor listener, so make sure that it is called last. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
this is ready for review |
jacobperron
approved these changes
Jun 30, 2022
gazebo/rendering/LensFlare.cc
Outdated
|
|
||
| /// \brief Number of steps to take in each direction when checking for | ||
| /// occlusion. | ||
| public: double occlusionSteps = 10; |
There was a problem hiding this comment.
Suggested change
| public: double occlusionSteps = 10; | |
| public: double occlusionSteps = 10.0; |
gazebo/rendering/LensFlare.cc
Outdated
| @@ -356,6 +367,9 @@ namespace gazebo | |||
| public: ignition::math::Vector3d lensFlareColor | |||
| = ignition::math::Vector3d(1.0, 1.0, 1.0); | |||
|
|
|||
| /// \brief Color of lens flare. | |||
| public: double lensFlareOcclusionSteps = 10; | |||
There was a problem hiding this comment.
Suggested change
| public: double lensFlareOcclusionSteps = 10; | |
| public: double lensFlareOcclusionSteps = 10.0; |
plugins/LensFlareSensorPlugin.cc
Outdated
| @@ -40,6 +40,9 @@ namespace gazebo | |||
| public: ignition::math::Vector3d color | |||
| = ignition::math::Vector3d(1.4, 1.2, 1.0); | |||
|
|
|||
| /// \brief Lens flare occlusion steps | |||
| public: double occlusionSteps = 10; | |||
There was a problem hiding this comment.
Suggested change
| public: double occlusionSteps = 10; | |
| public: double occlusionSteps = 10.0; |
…e_occlusion_steps
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
jacobperron
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some testing of the LensFlare effects has indicated that the number of steps used when checking for occlusions in
LensFlareCompositorListener::OcclusionScaleis impacting performance. To investigate, I've exposed it as a parameter in therendering::LensFlarec++ API and as an XML parameter<occlusion_steps>to theLensFlarePlugin.